michaeljmarshall opened a new pull request, #20132:
URL: https://github.com/apache/pulsar/pull/20132

   PIP: #12105 and #19771 
   
   ### Motivation
   
   With the implementation of asynchronous authentication in PIP 97, I missed a 
case in the `AuthenticationProviderList` where we need to implement the 
`authenticateAsync` methods. This PR is necessary for making the 
`AuthenticationProviderToken` and the `AuthenticationProviderOpenID` work 
together, which is necessary for anyone transitioning to 
`AuthenticationProviderOpenID`.
   
   ### Modifications
   
   * Implement `AuthenticationListState#authenticateAsync` using a recursive 
algorithm that first attempts to authenticate the client using the current 
`authState` and then tries the remaining options.
   * Implement `AuthenticationProviderList#authenticateAsync` using a recursive 
algorithm that attempts each provider sequentially.
   * Add test to `AuthenticationProviderListTest` that exercises this method. 
It didn't technically fail previously, but it's worth adding.
   * Add test to `AuthenticationProviderOpenIDIntegrationTest` to cover the 
exact failures that were causing problems.
   
   ### Verifying this change
   
   A new test is added and all existing tests pass.
   
   ### Documentation
   
   - [x] `doc-not-needed`
   
   ### Matching PR in forked repository
   
   PR in forked repository: Skipping since I was able to run the relevant tests 
locally


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to