KannarFr commented on code in PR #17411:
URL: https://github.com/apache/pulsar/pull/17411#discussion_r1171121469
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -1109,13 +1109,18 @@ protected void handleSubscribe(final CommandSubscribe
subscribe) {
TopicOperation.CONSUME
);
+ CompletableFuture<Boolean> isAuthorizedToCreateTopicFuture =
isNamespaceOperationAllowed(
+ topicName.getNamespaceObject(),
+ NamespaceOperation.CREATE_TOPIC
+ );
Review Comment:
That would be nice, but as I answered you am I not sure we can really do it
has CREATE_TOPIC check is already performed in HTTP admin checks.
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -1109,13 +1109,18 @@ protected void handleSubscribe(final CommandSubscribe
subscribe) {
TopicOperation.CONSUME
);
+ CompletableFuture<Boolean> isAuthorizedToCreateTopicFuture =
isNamespaceOperationAllowed(
+ topicName.getNamespaceObject(),
+ NamespaceOperation.CREATE_TOPIC
+ );
Review Comment:
That would be nice, but as I answered you am I not sure we can really do it
as CREATE_TOPIC check is already performed in HTTP admin checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
