codelipenghui commented on code in PR #20131:
URL: https://github.com/apache/pulsar/pull/20131#discussion_r1171170688
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -1171,6 +1172,16 @@ protected CompletableFuture<Void>
internalDeleteTopicAsync(boolean authoritative
.thenCompose(__ ->
pulsar().getBrokerService().deleteTopic(topicName.toString(), force));
}
+ private boolean hitsTheIssue18149(PartitionedTopicMetadata topicMetadata) {
Review Comment:
```suggestion
private boolean isUnexpectedTopicName(PartitionedTopicMetadata
topicMetadata) {
```
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -1171,6 +1172,16 @@ protected CompletableFuture<Void>
internalDeleteTopicAsync(boolean authoritative
.thenCompose(__ ->
pulsar().getBrokerService().deleteTopic(topicName.toString(), force));
}
+ private boolean hitsTheIssue18149(PartitionedTopicMetadata topicMetadata) {
Review Comment:
We can add the issue link as a comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
