michaeljmarshall commented on code in PR #17411:
URL: https://github.com/apache/pulsar/pull/17411#discussion_r1171527978
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -1109,13 +1109,18 @@ protected void handleSubscribe(final CommandSubscribe
subscribe) {
TopicOperation.CONSUME
);
+ CompletableFuture<Boolean> isAuthorizedToCreateTopicFuture =
isNamespaceOperationAllowed(
+ topicName.getNamespaceObject(),
+ NamespaceOperation.CREATE_TOPIC
+ );
Review Comment:
While I agree that the current design is inconsistent, I don't think we
should add logic that breaks existing use cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
