codelipenghui commented on code in PR #20128:
URL: https://github.com/apache/pulsar/pull/20128#discussion_r1172025749


##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ReplicatorTest.java:
##########
@@ -1756,4 +1763,93 @@ public void testReplicatorProducerNotExceed() throws 
Exception {
 
         Assert.assertThrows(PulsarClientException.ProducerBusyException.class, 
() -> new MessageProducer(url2, dest2));
     }
+
+    @Test
+    public void testDiscontinuousMessages() throws Exception {

Review Comment:
   > This scenario is hard to fix. Because there is no clear marker of which 
in-flight reads need to be discarded after step-2. I think I should learn how 
the connector handle messages.
   
   But we will not get an error if the message is duplicated, right? The broker 
skips the duplicated sends and returns (-1, -1) as the message ID. We are safe 
to publish messages 1 to 5 again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to