Jason918 commented on code in PR #20161:
URL: https://github.com/apache/pulsar/pull/20161#discussion_r1173493852
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -844,6 +844,26 @@ The delayed message index time step(in seconds) in per
bucket snapshot segment,
+ "it can be enabled to reduce the memory consumption
caused by pendingAcks.")
private boolean autoShrinkForConsumerPendingAcksMap = false;
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ dynamic = true,
+ doc = "The minimum receive buffer size for
AdaptiveRecvByteBufAllocator"
Review Comment:
Can you add more doc to guiding user to tune the value of this config?
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -844,6 +844,26 @@ The delayed message index time step(in seconds) in per
bucket snapshot segment,
+ "it can be enabled to reduce the memory consumption
caused by pendingAcks.")
private boolean autoShrinkForConsumerPendingAcksMap = false;
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ dynamic = true,
+ doc = "The minimum receive buffer size for
AdaptiveRecvByteBufAllocator"
+ )
+ private int minReceiveByteBuf = 1024;
Review Comment:
Please make the config name more descriptive. Maybe like
`minReceiveSizeForNettyByteBufAllocator` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
