michaeljmarshall commented on code in PR #20030:
URL: https://github.com/apache/pulsar/pull/20030#discussion_r1176776887
##########
pulsar-broker-auth-oidc/src/main/java/org/apache/pulsar/broker/authentication/oidc/AuthenticationProviderOpenID.java:
##########
@@ -447,7 +447,7 @@ DecodedJWT verifyJWT(PublicKey publicKey,
}
static void incrementFailureMetric(AuthenticationExceptionCode code) {
- AuthenticationMetrics.authenticateFailure(SIMPLE_NAME, "token",
code.toString());
+ AuthenticationMetrics.authenticateFailure(SIMPLE_NAME, "openid", code);
Review Comment:
I don't think this is necessary because the `SIMPLE_NAME` is the class's
name, which has `openid` in it. I wonder if we really even need the auth method
if we also have the class name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
