liqiangcc commented on PR #20219:
URL: https://github.com/apache/pulsar/pull/20219#issuecomment-1534639478

   > The `addAll()` will also has a iteration operation, I wonder will `addAll` 
will be more efficient than iteration
   
   Thanks for your reivew,`addAll()`  and `putAll()` internal implementation 
also has a iteration operation, fortunately, HashMap's `putAll()` method resize 
before iteration, so it is more efficient. And looks cleaner.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to