[pulsar] branch master updated: [improve][broker] Use bulk operation instead of iteration (#20219)

[zixuan]

This is an automated email from the ASF dual-hosted git repository.

zixuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new 9cb0503bbfb [improve][broker] Use bulk operation instead of iteration 
(#20219)
9cb0503bbfb is described below

commit 9cb0503bbfb442c44be201c5bae28a34a3cd8edf
Author: Liqiangcc <43640935+liqian...@users.noreply.github.com>
AuthorDate: Sat May 6 23:31:12 2023 +0800

    [improve][broker] Use bulk operation instead of iteration (#20219)
---
 .../org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java    | 2 +-
 .../pulsar/broker/resourcegroup/ResourceGroupConfigListener.java     | 4 +---
 .../src/main/java/org/apache/pulsar/broker/service/PulsarStats.java  | 5 ++---
 3 files changed, 4 insertions(+), 7 deletions(-)

diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
index fcade8270cb..9dcbe13d615 100644
--- 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
+++ 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
@@ -226,7 +226,7 @@ public class PersistentTopicsBase extends AdminResource {
                 String topicUri = topicName.toString();
                 AuthPolicies auth = policies.get().auth_policies;
                 // First add namespace level permissions
-                auth.getNamespaceAuthentication().forEach(permissions::put);
+                permissions.putAll(auth.getNamespaceAuthentication());
 
                 // Then add topic level permissions
                 if (auth.getTopicAuthentication().containsKey(topicUri)) {
diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java
 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java
index 5428d12ebad..c15edd2be4e 100644
--- 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java
+++ 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupConfigListener.java
@@ -68,9 +68,7 @@ public class ResourceGroupConfigListener implements 
Consumer<Notification> {
             final Set<String> existingSet = rgService.resourceGroupGetAll();
             HashSet<String> newSet = new HashSet<>();
 
-            for (String rgName : rgList) {
-                newSet.add(rgName);
-            }
+            newSet.addAll(rgList);
 
             final Sets.SetView<String> deleteList = 
Sets.difference(existingSet, newSet);
 
diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarStats.java 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarStats.java
index 2059aa04350..e959e9bbda2 100644
--- 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarStats.java
+++ 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarStats.java
@@ -204,11 +204,10 @@ public class PulsarStats implements Closeable {
                 }
             });
             if (clusterReplicationMetrics.isMetricsEnabled()) {
-                clusterReplicationMetrics.get().forEach(clusterMetric -> 
tempMetricsCollection.add(clusterMetric));
+                tempMetricsCollection.addAll(clusterReplicationMetrics.get());
                 clusterReplicationMetrics.reset();
             }
-            brokerOperabilityMetrics.getMetrics()
-                    .forEach(brokerOperabilityMetric -> 
tempMetricsCollection.add(brokerOperabilityMetric));
+            
tempMetricsCollection.addAll(brokerOperabilityMetrics.getMetrics());
 
             // json end
             topicStatsStream.endObject();