poorbarcode commented on code in PR #20235:
URL: https://github.com/apache/pulsar/pull/20235#discussion_r1186970727
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/SnapshotSegmentAbortedTxnProcessorImpl.java:
##########
@@ -265,7 +266,7 @@ public CompletableFuture<PositionImpl>
recoverFromSnapshot() {
PositionImpl finalStartReadCursorPosition =
startReadCursorPosition;
TransactionBufferSnapshotIndexes
finalPersistentSnapshotIndexes = persistentSnapshotIndexes;
if (persistentSnapshotIndexes == null) {
Review Comment:
After turning on the feature `transactionBufferSegmentedSnapshotEnabled,` if
users create a new topic, the method `recoverOldSnapshot` will trigger the
creation of the topic `__transaction_buffer_snapshot`, but it is not needed,
right?
And can we add a test to guarantee this issue will not occur?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
