shibd commented on code in PR #322:
URL:
https://github.com/apache/pulsar-client-node/pull/322#discussion_r1186980916
##########
tests/end_to_end.test.js:
##########
@@ -1242,5 +1242,21 @@ const Pulsar = require('../index.js');
await consumer.close();
await client.close();
});
+
+ test('Client/getPartitionsForTopic', async () => {
Review Comment:
This test should belong `client.test.js`.
##########
tests/end_to_end.test.js:
##########
@@ -1242,5 +1242,21 @@ const Pulsar = require('../index.js');
await consumer.close();
await client.close();
});
+
+ test('Client/getPartitionsForTopic', async () => {
+ const client = new Pulsar.Client({
+ serviceUrl: 'pulsar://localhost:6650',
+ operationTimeoutSeconds: 30,
+ });
+
+ const topic = 'persistent://public/default/get-partitions-for-topic';
+ await client.createProducer({
Review Comment:
You can use admin [REST
API](https://pulsar.apache.org/admin-rest-api/?version=3.0.0#) to create
specified partitions topic, and then to assert `getPartitionsForTopic`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
