tisonkun commented on code in PR #20259:
URL: https://github.com/apache/pulsar/pull/20259#discussion_r1188018359


##########
pulsar-io/jdbc/core/pom.xml:
##########
@@ -58,6 +58,13 @@
       <groupId>com.fasterxml.jackson.dataformat</groupId>
       <artifactId>jackson-dataformat-yaml</artifactId>
     </dependency>
+
+    <dependency>
+      <groupId>com.google.protobuf</groupId>
+      <artifactId>protobuf-java</artifactId>
+      <version>3.22.4</version>

Review Comment:
   @bpereto Also, please verify that `provided` statisfy your use case. One 
downside of `provided` is that - I'm not sure - if we don't pack protobuf into 
the NARball, it's possible to meet `NoClassDefFoundError`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to