csthomas1 opened a new pull request, #19584:
URL: https://github.com/apache/pulsar/pull/19584
Make KubernetesRuntime translate tenant, namespace, and function name
characters that are not allowed within Kubernetes labels as part of function
removal.
Fixes #19583
### Motivation
See linked issue ticket.
### Modifications
Updated KubernetesRuntime.deleteStatefulSet() to pass function tenant,
namespace, and name values through the pre-existing getLabels() function to
replace disallowed characters.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
Adds the following test cases:
- KubernetesRuntimeTest:
- testDeleteStatefulSetWithTranslatedKubernetesLabelChars(): Verifies that
characters not supported by Kubernetes naming requirements are translated to
acceptable forms
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update
later -->
- [X] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: (https://github.com/csthomas1/pulsar/pull/1)
(All tests passed -- the Flaky tests failure occurs after execution of the
tests themselves and appears to be due to a failed CodeCov upload attempt)
<!--
After opening this PR, the build in apache/pulsar will fail and instructions
will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since
the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed
in
a forked repository.
The tests will be run in the forked repository until all PR review comments
have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
