lhotari commented on PR #18688:
URL: https://github.com/apache/pulsar/pull/18688#issuecomment-1541947065

   > Could you please help review this PR?
   
   @poorbarcode The change to production code itself looks good, but I don't 
like the test. Addressing that would require more changes to ML factory to make 
it possible to sub class it for tests with test hooks instead of relying on 
Mockito.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to