This is an automated email from the ASF dual-hosted git repository.
technoboy pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new c32caba54a5 [fix][broker] Fix default bundle size used while setting
bookie affinity (#20250)
c32caba54a5 is described below
commit c32caba54a5ab2c01c092ab952343f4ac405da35
Author: Raghavender Mittapalli <[email protected]>
AuthorDate: Wed May 10 18:05:17 2023 +0530
[fix][broker] Fix default bundle size used while setting bookie affinity
(#20250)
---
.../main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java | 2 +-
.../org/apache/pulsar/broker/service/BrokerBookieIsolationTest.java | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
index 19f8d7c437d..8c72d0b0286 100644
---
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
+++
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
@@ -883,7 +883,7 @@ public abstract class NamespacesBase extends AdminResource {
policies -> new LocalPolicies(policies.bundles,
bookieAffinityGroup,
policies.namespaceAntiAffinityGroup))
- .orElseGet(() -> new LocalPolicies(defaultBundle(),
+ .orElseGet(() -> new
LocalPolicies(getBundles(config().getDefaultNumberOfNamespaceBundles()),
bookieAffinityGroup,
null));
log.info("[{}] Successfully updated local-policies
configuration: namespace={}, map={}", clientAppId(),
diff --git
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerBookieIsolationTest.java
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerBookieIsolationTest.java
index 36d4053ae49..951892f4ebf 100644
---
a/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerBookieIsolationTest.java
+++
b/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerBookieIsolationTest.java
@@ -156,6 +156,7 @@ public class BrokerBookieIsolationTest {
config.setBrokerServicePort(Optional.of(0));
config.setAdvertisedAddress("localhost");
config.setBookkeeperClientIsolationGroups(brokerBookkeeperClientIsolationGroups);
+ config.setDefaultNumberOfNamespaceBundles(8);
config.setManagedLedgerDefaultEnsembleSize(2);
config.setManagedLedgerDefaultWriteQuorum(2);
@@ -207,6 +208,9 @@ public class BrokerBookieIsolationTest {
.bookkeeperAffinityGroupPrimary(tenantNamespaceIsolationGroups)
.build());
+ //Checks the namespace bundles after setting the bookie affinity
+ assertEquals(admin.namespaces().getBundles(ns2).getNumBundles(),
config.getDefaultNumberOfNamespaceBundles());
+
try {
admin.namespaces().getBookieAffinityGroup(ns1);
fail("ns1 should have no bookie affinity group set");