equanz commented on PR #20179: URL: https://github.com/apache/pulsar/pull/20179#issuecomment-1543445903
@eolivelli Thank you for your comments. I'll check it. By the way, do you have any comments about the following concern from @poorbarcode ? > By the way, if there are a huge number of keys, will the constructor LastSentPositions cost too much memory? If the current approach is not approved, I create the next PR as in https://github.com/apache/pulsar/pull/20179#issuecomment-1539314184 instead of addressing your comments in this PR. --- @poorbarcode What do you think about the following comment? https://github.com/apache/pulsar/pull/20179#issuecomment-1539314184 * I think we can't split easily between fix and improvement in the current approach. - For more details, please see the description("2. Keep the last sent position per key."). * I think we need to implement a new feature like https://github.com/apache/pulsar/pull/20179#issuecomment-1539314184 to fix without introducing Map structure. * My primary motivation is not to improve Key_Shared but fix Key_Shared. Therefore, if the current approach is not approved as a fix, I introduce it and remove the feature by Map per key. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
