lifepuzzlefun commented on code in PR #20276:
URL: https://github.com/apache/pulsar/pull/20276#discussion_r1192206274
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -4353,7 +4353,22 @@ public void checkInactiveLedgerAndRollOver() {
long currentTimeMs = System.currentTimeMillis();
if (inactiveLedgerRollOverTimeMs > 0 && currentTimeMs >
(lastAddEntryTimeMs + inactiveLedgerRollOverTimeMs)) {
log.info("[{}] Closing inactive ledger, last-add entry {}", name,
lastAddEntryTimeMs);
- ledgerClosed(currentLedger);
+ if (STATE_UPDATER.compareAndSet(this, State.LedgerOpened,
State.ClosingLedger)) {
+ LedgerHandle currentLedger = this.currentLedger;
+ currentLedger.asyncClose((rc, lh, o) -> {
+ checkArgument(currentLedger.getId() == lh.getId(),
"ledgerId %s doesn't match with "
+ + "acked ledgerId %s", currentLedger.getId(),
lh.getId());
+
+ if (rc == Code.OK) {
+ log.debug("Successfully closed ledger {}", lh.getId());
+ } else {
+ log.warn("Error when closing ledger {}. Status={}",
lh.getId(), BKException.getMessage(rc));
Review Comment:
yeah~ fix have been submitted, it looks with more detail now. nice
suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
