poorbarcode commented on code in PR #20189:
URL: https://github.com/apache/pulsar/pull/20189#discussion_r1192410763
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:
##########
@@ -1137,6 +1137,10 @@ public CompletableFuture<Boolean>
isServiceUnitOwnedAsync(ServiceUnitId suName)
new IllegalArgumentException("Invalid class of
NamespaceBundle: " + suName.getClass().getName()));
}
+ /**
+ * @Deprecated This method is only used by test. call
"isServiceUnitActiveAsync" is better.
+ */
+ @Deprecated
public boolean isServiceUnitActive(TopicName topicName) {
try {
Review Comment:
@lhotari
I think it is a good suggestion. Already edit this method to make the test
that calls the method works better.
Could you take a look again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
