Anonymitaet commented on code in PR #567:
URL: https://github.com/apache/pulsar-site/pull/567#discussion_r1193240240


##########
docs/reference-metrics.md:
##########
@@ -600,6 +600,67 @@ All the metadata store metrics are labeled with the 
following labels:
 | pulsar_batch_metadata_store_batch_execute_time_ms  | Histogram | The 
duration of the batch execution in milliseconds.                                
         |
 | pulsar_batch_metadata_store_batch_size             | Histogram | The number 
of read/write operations in the batch.                                          
  |
 
+### JVM Metrics
+
+#### Process Metrics
+| Name                                               | Type    | Description   
                                                                               |
+|----------------------------------------------------|---------|----------------------------------------------------------------------------------------------|
+| process_cpu_seconds_total                  | Counter | Total user and system 
CPU time spent in seconds.                         |
+| process_start_time_seconds | Gauge   | Start time of the process since unix 
epoch in seconds. |
+| process_open_fds | Gauge | Number of open file descriptors. |
+| process_max_fds | Gauge | Maximum number of open file descriptors. |
+| process_virtual_memory_bytes | Gauge | Virtual memory size in bytes. |
+| process_resident_memory_bytes | Gauge | Resident memory size in bytes. |
+
+#### Memory Metrics
+| Name                                               | Type    | Description   
                                                                               |
+|----------------------------------------------------|---------|----------------------------------------------------------------------------------------------|
+| jvm_memory_objects_pending_finalization | Gauge | The number of objects 
waiting in the finalizer queue. |
+| jvm_memory_bytes_used | Gauge | Used bytes of a given JVM memory area. |
+| jvm_memory_bytes_committed | Gauge | Committed (bytes) of a given JVM memory 
area. |
+| jvm_memory_bytes_max | Gauge | Max (bytes) of a given JVM memory area. |
+| jvm_memory_bytes_init | Gauge | Initial bytes of a given JVM memory area. |
+| jvm_memory_pool_bytes_used | Used bytes of a given JVM memory pool. |
+| jvm_memory_pool_bytes_committed | Gauge | Committed bytes of a given JVM 
memory pool. |
+| jvm_memory_pool_bytes_max | Gauge | Max bytes of a given JVM memory pool. |
+| jvm_memory_pool_bytes_init | Gauge | Initial bytes of a given JVM memory 
pool. |
+| jvm_memory_pool_collection_used_bytes | Gauge | Used bytes after last 
collection of a given JVM memory pool. |

Review Comment:
   ```suggestion
   | jvm_memory_pool_collection_used_bytes | Gauge | Used bytes after the last 
collection of a given JVM memory pool. |
   ```



##########
docs/reference-metrics.md:
##########
@@ -600,6 +600,67 @@ All the metadata store metrics are labeled with the 
following labels:
 | pulsar_batch_metadata_store_batch_execute_time_ms  | Histogram | The 
duration of the batch execution in milliseconds.                                
         |
 | pulsar_batch_metadata_store_batch_size             | Histogram | The number 
of read/write operations in the batch.                                          
  |
 
+### JVM Metrics
+
+#### Process Metrics
+| Name                                               | Type    | Description   
                                                                               |
+|----------------------------------------------------|---------|----------------------------------------------------------------------------------------------|
+| process_cpu_seconds_total                  | Counter | Total user and system 
CPU time spent in seconds.                         |
+| process_start_time_seconds | Gauge   | Start time of the process since unix 
epoch in seconds. |
+| process_open_fds | Gauge | Number of open file descriptors. |
+| process_max_fds | Gauge | Maximum number of open file descriptors. |
+| process_virtual_memory_bytes | Gauge | Virtual memory size in bytes. |
+| process_resident_memory_bytes | Gauge | Resident memory size in bytes. |
+
+#### Memory Metrics
+| Name                                               | Type    | Description   
                                                                               |
+|----------------------------------------------------|---------|----------------------------------------------------------------------------------------------|
+| jvm_memory_objects_pending_finalization | Gauge | The number of objects 
waiting in the finalizer queue. |
+| jvm_memory_bytes_used | Gauge | Used bytes of a given JVM memory area. |
+| jvm_memory_bytes_committed | Gauge | Committed (bytes) of a given JVM memory 
area. |
+| jvm_memory_bytes_max | Gauge | Max (bytes) of a given JVM memory area. |
+| jvm_memory_bytes_init | Gauge | Initial bytes of a given JVM memory area. |
+| jvm_memory_pool_bytes_used | Used bytes of a given JVM memory pool. |
+| jvm_memory_pool_bytes_committed | Gauge | Committed bytes of a given JVM 
memory pool. |
+| jvm_memory_pool_bytes_max | Gauge | Max bytes of a given JVM memory pool. |
+| jvm_memory_pool_bytes_init | Gauge | Initial bytes of a given JVM memory 
pool. |
+| jvm_memory_pool_collection_used_bytes | Gauge | Used bytes after last 
collection of a given JVM memory pool. |
+| jvm_memory_pool_collection_committed_bytes | Gauge | Committed after last 
collection bytes of a given JVM memory pool. |
+| jvm_memory_pool_collection_max_bytes | Gauge | Max bytes after last 
collection of a given JVM memory pool. |

Review Comment:
   Same comments for versioned docs.



##########
docs/reference-metrics.md:
##########
@@ -600,6 +600,67 @@ All the metadata store metrics are labeled with the 
following labels:
 | pulsar_batch_metadata_store_batch_execute_time_ms  | Histogram | The 
duration of the batch execution in milliseconds.                                
         |
 | pulsar_batch_metadata_store_batch_size             | Histogram | The number 
of read/write operations in the batch.                                          
  |
 
+### JVM Metrics
+
+#### Process Metrics
+| Name                                               | Type    | Description   
                                                                               |
+|----------------------------------------------------|---------|----------------------------------------------------------------------------------------------|
+| process_cpu_seconds_total                  | Counter | Total user and system 
CPU time spent in seconds.                         |
+| process_start_time_seconds | Gauge   | Start time of the process since unix 
epoch in seconds. |
+| process_open_fds | Gauge | Number of open file descriptors. |
+| process_max_fds | Gauge | Maximum number of open file descriptors. |
+| process_virtual_memory_bytes | Gauge | Virtual memory size in bytes. |
+| process_resident_memory_bytes | Gauge | Resident memory size in bytes. |
+
+#### Memory Metrics
+| Name                                               | Type    | Description   
                                                                               |
+|----------------------------------------------------|---------|----------------------------------------------------------------------------------------------|
+| jvm_memory_objects_pending_finalization | Gauge | The number of objects 
waiting in the finalizer queue. |
+| jvm_memory_bytes_used | Gauge | Used bytes of a given JVM memory area. |
+| jvm_memory_bytes_committed | Gauge | Committed (bytes) of a given JVM memory 
area. |
+| jvm_memory_bytes_max | Gauge | Max (bytes) of a given JVM memory area. |
+| jvm_memory_bytes_init | Gauge | Initial bytes of a given JVM memory area. |
+| jvm_memory_pool_bytes_used | Used bytes of a given JVM memory pool. |
+| jvm_memory_pool_bytes_committed | Gauge | Committed bytes of a given JVM 
memory pool. |
+| jvm_memory_pool_bytes_max | Gauge | Max bytes of a given JVM memory pool. |
+| jvm_memory_pool_bytes_init | Gauge | Initial bytes of a given JVM memory 
pool. |
+| jvm_memory_pool_collection_used_bytes | Gauge | Used bytes after last 
collection of a given JVM memory pool. |
+| jvm_memory_pool_collection_committed_bytes | Gauge | Committed after last 
collection bytes of a given JVM memory pool. |
+| jvm_memory_pool_collection_max_bytes | Gauge | Max bytes after last 
collection of a given JVM memory pool. |

Review Comment:
   ```suggestion
   | jvm_memory_pool_collection_max_bytes | Gauge | Max bytes after the last 
collection of a given JVM memory pool. |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to