tisonkun commented on code in PR #20325:
URL: https://github.com/apache/pulsar/pull/20325#discussion_r1194531648


##########
.asf.yaml:
##########
@@ -35,12 +35,9 @@ github:
     # Enable projects for project management boards
     projects: true
   enabled_merge_buttons:
-    # enable squash button:
     squash:  true
-    # disable merge button:
     merge:   false
-    # disable rebase button:
-    rebase:  false
+    rebase:  true

Review Comment:
   OK. Let me start a mail thread first.
   
   For documentation, I don't think committers read comments in `.asf.yaml` so 
probably a page under 
https://pulsar.apache.org/contribute/develop-coding-conventions/ said 
"Reviewing Pull Request" or "Merging Pull Request".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to