[GitHub] [pulsar] poorbarcode commented on a diff in pull request #18620: [fix][broker] If ledger lost, cursor mark delete position can not forward

[via GitHub]

poorbarcode commented on code in PR #18620:
URL: https://github.com/apache/pulsar/pull/18620#discussion_r1194569568


##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -480,7 +482,24 @@ public void operationComplete(ManagedCursorInfo info, Stat 
stat) {
                     // Need to proceed and read the last entry in the 
specified ledger to find out the last position
                     log.info("[{}] Consumer {} meta-data recover from ledger 
{}", ledger.getName(), name,
                             info.getCursorsLedgerId());
-                    recoverFromLedger(info, callback);
+                    recoverFromLedger(info, new VoidCallback() {
+                        @Override
+                        public void operationComplete() {
+                            LinkedHashSet<Long> ledgersDeletedButNotAcked = 
checkLedgersDeletedButNotAcked();

Review Comment:
   these codes have been removed(This PR no longer call the checks when cursor 
is initializing)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org