michaeljmarshall opened a new pull request, #20343: URL: https://github.com/apache/pulsar/pull/20343
### Motivation @dave2wave recently encountered this test failure: ``` 20:46:55 [ERROR] Tests run: 2, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 15.301 s <<< FAILURE! - in org.apache.pulsar.broker.loadbalance.LoadReportNetworkLimitTest 20:46:55 [ERROR] checkLoadReportNicSpeed(org.apache.pulsar.broker.loadbalance.LoadReportNetworkLimitTest) Time elapsed: 0.142 s <<< FAILURE! 20:46:55 java.lang.AssertionError: expected [1.6200000000000004E7] but found [1.62E7] 20:46:55 at org.testng.Assert.fail(Assert.java:99) 20:46:55 at org.testng.Assert.failNotEquals(Assert.java:1037) 20:46:55 at org.testng.Assert.assertEquals(Assert.java:701) 20:46:55 at org.testng.Assert.assertEquals(Assert.java:712) 20:46:55 at org.apache.pulsar.broker.loadbalance.LoadReportNetworkLimitTest.checkLoadReportNicSpeed(LoadReportNetworkLimitTest.java:63) ``` The test failed because we are not providing an acceptable delta for the equality check. It looks like there are other tests where we have strict double or float comparisons. I am going to leave those for now to minimize the diff on this PR. I read through all of the open flaky test issues and none appear to be related to this class of flakiness. ### Modifications * Add a delta to the assertions in the `checkLoadReportNicSpeed` test ### Verifying this change This change is a trivial rework / code cleanup without any test coverage. ### Documentation - [x] `doc-not-needed` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
