michaeljmarshall commented on code in PR #20348:
URL: https://github.com/apache/pulsar/pull/20348#discussion_r1197827247
##########
pulsar-proxy/src/test/java/org/apache/pulsar/proxy/server/ProxyWithoutServiceDiscoveryTest.java:
##########
@@ -198,10 +196,10 @@ public void testDiscoveryService() throws Exception {
}
protected final PulsarClient createPulsarClient(Authentication auth,
String lookupUrl) throws Exception {
- admin =
spy(PulsarAdmin.builder().serviceHttpUrl(brokerUrlTls.toString()).tlsTrustCertsFilePath(TLS_TRUST_CERT_FILE_PATH)
-
.allowTlsInsecureConnection(true).authentication(auth).build());
Review Comment:
The test is documented as verifying end to end TLS, but this setting
disables verification of the TLS certificate, which defeats the purpose of
testing TLS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
