visortelle commented on PR #560: URL: https://github.com/apache/pulsar-site/pull/560#issuecomment-1554073315
@Anonymitaet thank you for the review. 😀 > The texts look a little dense. What are the default text size and line spacing? Does it make sense to increase them a bit to increase reliability? The text size is 16px. I increased the line-height a bit from 24px to 26px (1.625). > Do we need to keep consistent on "regular" or "bold"? h1 and h2 headers have regular fort by design. <img width="687" alt="Screenshot 2023-05-19 at 7 36 01 AM" src="https://github.com/apache/pulsar-site/assets/9302460/30bc9c3c-f374-4db8-b250-de67cecb7be7";> https://www.figma.com/file/0jERoA2DTlfQoj1uH09FxQ/Pulsar-website?type=design&node-id=254-422&t=0DUnBCdzrLQVUWdj-0 For me, it looks normal. Probably we can keep it for other pages, and make the bold for docs pages. @emidio-cardeira WDYT? > Does it make sense to change "note" background color to more prominent one (e.g. blue) since it requests attention? Docusaurus has a special syntax for that: https://docusaurus.io/docs/markdown-features/admonitions. <img width="812" alt="Screenshot 2023-05-19 at 7 54 17 AM" src="https://github.com/apache/pulsar-site/assets/9302460/4607f61e-04c4-4027-8fa1-d58ab07ff717";> Using `:::info` <img width="848" alt="Screenshot 2023-05-19 at 7 51 40 AM" src="https://github.com/apache/pulsar-site/assets/9302460/32689d63-99f1-4aa5-80a6-8329150ac1d2";> Using `:::caution` <img width="841" alt="Screenshot 2023-05-19 at 7 52 36 AM" src="https://github.com/apache/pulsar-site/assets/9302460/bb393f8b-032d-43ac-8953-8772122eac2b";> For me, it makes sense to distinguish blocks visually that provide more details or give pro tips, and blocks that contain information about potentially destructive actions. @asafm WDYT? I found 244 `:::note` entries in the `/docs` dir. Not too many. @Anonymitaet if you want, I can help you with changing it to tip/info/caution/danger. > Tables. Update this light gray to a little darker one? I updated it to the gray color that is used in other places. For me, contrast is enough. :) <img width="833" alt="Screenshot 2023-05-19 at 8 05 59 AM" src="https://github.com/apache/pulsar-site/assets/9302460/3139baf1-14af-4513-8c87-e7e6ecc25e32";> Higher contrast doesn't look good. <img width="840" alt="Screenshot 2023-05-19 at 8 13 35 AM" src="https://github.com/apache/pulsar-site/assets/9302460/15118ab1-92e3-4a83-b1d8-31d2ac6dedaf";> @emidio-cardeira WDYT? > Logo. Why change this from blue to black? Maybe @emidio-cardeira or @asafm can give a good answer here. > it's more reasonable to update this value to 10ms. Updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
