pgier opened a new pull request, #20359: URL: https://github.com/apache/pulsar/pull/20359
Renames two rest endpoint methods which were incorrectly named and cause an ID conflict in the generated swagger. This change also skips the license check when generating the swagger spec file. ### Motivation Swagger generation uses the method/function name for the ID of the endpoint. This causes problems downstream when trying to generate admin client sources based on the swagger. ### Modifications Changed two method names related to namespace endpoints that didn't match the endpoint. This does not affect the rest endpoints, just the method names backing them. ### Verifying this change - [X] Make sure that the change passes the CI checks. This change is already covered by existing tests. ### Does this pull request potentially affect one of the following parts: <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [X] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: https://github.com/pgier/pulsar/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
