Anonymitaet commented on code in PR #20374:
URL: https://github.com/apache/pulsar/pull/20374#discussion_r1203299664
##########
conf/broker.conf:
##########
@@ -582,7 +580,7 @@ delayedDeliveryMaxIndexesPerBucketSnapshotSegment=5000
delayedDeliveryMaxNumBuckets=-1
# Size of the lookahead window to use when detecting if all the messages in
the topic
-# have a fixed delay.
+# have a fixed delay for InMemoryDelayedDeliveryTracker (the default
DelayedDeliverTracker).
Review Comment:
```suggestion
# have a fixed delay for InMemoryDelayedDeliveryTracker (the default value
is DelayedDeliverTracker).
```
Do you mean this?
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -379,7 +377,8 @@ The delayed message index time step(in seconds) in per
bucket snapshot segment,
private int delayedDeliveryMaxNumBuckets = -1;
@FieldContext(category = CATEGORY_SERVER, doc = "Size of the lookahead
window to use "
- + "when detecting if all the messages in the topic have a fixed
delay. "
+ + "when detecting if all the messages in the topic have a fixed
delay for "
+ + "InMemoryDelayedDeliveryTracker (the default
DelayedDeliverTracker). "
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
