thetumbled opened a new pull request, #20396:
URL: https://github.com/apache/pulsar/pull/20396

   <!-- Either this PR fixes an issue, -->
   
   Fixes #20395
   
   
   ### Motivation
   
   
org.apache.pulsar.broker.TransactionMetadataStoreService#handleTcClientConnect
   
![image](https://github.com/apache/pulsar/assets/52550727/aa1013f0-d34b-454c-bdb2-3dc392359169)
   
   The real cause may be wrapped in the CompletionException, we should unwrap 
the real cause from CompletionException and complete the request with real 
causes like this:
   <img width="550" alt="image" 
src="https://github.com/apache/pulsar/assets/52550727/bc0b3f5c-4379-4acf-9995-ec2de4ef5b6b";>
   
   ### Modifications
   
   unwrap the completion exception to retrieve real cause.
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   
   ### Does this pull request potentially affect one of the following parts:
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [ ] The metrics
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to