eolivelli commented on code in PR #20417:
URL: https://github.com/apache/pulsar/pull/20417#discussion_r1208593503
##########
pulsar-common/src/test/java/org/apache/pulsar/common/util/netty/DnsResolverTest.java:
##########
@@ -18,24 +18,29 @@
*/
package org.apache.pulsar.common.util.netty;
+import static org.assertj.core.api.Assertions.assertThat;
import io.netty.channel.EventLoop;
+import io.netty.resolver.dns.DnsNameResolver;
import io.netty.resolver.dns.DnsNameResolverBuilder;
+import java.util.concurrent.CountDownLatch;
+import java.util.concurrent.TimeUnit;
+import org.mockito.MockedConstruction;
import org.mockito.Mockito;
-import org.testng.Assert;
import org.testng.annotations.Test;
public class DnsResolverTest {
@Test
- public void testMaxTtl() {
- EventLoop eventLoop = Mockito.mock(EventLoop.class);
- DnsNameResolverBuilder dnsNameResolverBuilder = new
DnsNameResolverBuilder(eventLoop);
+ public void testMaxTtl() throws Exception {
Review Comment:
please remove this change that seems unrelated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
