lhotari opened a new pull request, #20425:
URL: https://github.com/apache/pulsar/pull/20425
### Motivation
In order to investigate some flaky test failures such as #20386, it is
necessary to add logging to find out what was the failure of the first attempt.
In some cases, the exception in the test retry is not the root cause.
In the case of #20386, there's "Index 0 out of bounds for length 0" recorded
in the skip message:
```
<testcase name="testMsgDropStat"
classname="org.apache.pulsar.client.api.NonPersistentTopicTest" time="0">
<skipped message="Index 0 out of bounds for length 0"/>
```
However, the full exception isn't logged.
### Modifications
- Log possible exceptions before retrying a test run
- this will help debug issues when tests are retried
- Don't log anything when skipping is a result of fail fast mode
(SkipException)
- Execute cleanup methods when using fail fast mode
- the change in #19252 broke the logic that intends to run cleanup methods
after the first failure
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update
later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
