[GitHub] [pulsar] Technoboy- commented on a diff in pull request #20406: [feat][broker]PIP-255 Part-1: Add listener interface for namespace service

[via GitHub]

Technoboy- commented on code in PR #20406:
URL: https://github.com/apache/pulsar/pull/20406#discussion_r1209346369


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:
##########
@@ -1230,6 +1236,18 @@ protected void onNamespaceBundleUnload(NamespaceBundle 
bundle) {
         }
     }
 
+    protected void onNamespaceBundleSplit(NamespaceBundle bundle) {
+        for (NamespaceBundleSplitListener bundleSplitListener : 
bundleSplitListeners) {
+            try {
+                if (bundleSplitListener.test(bundle)) {
+                    bundleSplitListener.onSplit(bundle);
+                }
+            } catch (Throwable t) {
+                LOG.error("Call bundle {} split lister error", bundle, t);

Review Comment:
   `LOG.error("Call bundle {} split lister {} error", 
bundle,bundleSplitListener, t);`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org