lhotari commented on code in PR #20326:
URL: https://github.com/apache/pulsar/pull/20326#discussion_r1212933540
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -1779,7 +1779,6 @@ long getNumIndividualDeletedEntriesToSkip(long
numEntries) {
} finally {
if (r.lowerEndpoint() instanceof PositionImplRecyclable) {
((PositionImplRecyclable) r.lowerEndpoint()).recycle();
Review Comment:
@crossoverJie @liangyepianzhou I have a question about this change.
issue #20262 description contains "The reason for this issue is that the
recycle() function reuses objects, causing the object referenced by r to change
during runtime."
What is the reason that the lowerEndpoint is recycled and the upperEndpoint
isn't?
why not just skip recycling completely? Omitting recycling completely would
be fine if recycling is problematic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
