lhotari commented on code in PR #20460:
URL: https://github.com/apache/pulsar/pull/20460#discussion_r1213424256
##########
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/PulsarAdminBuilder.java:
##########
@@ -327,4 +329,21 @@ PulsarAdminBuilder authentication(String
authPluginClassName, Map<String, String
*/
PulsarAdminBuilder setContextClassLoader(ClassLoader
clientBuilderClassLoader);
+
+ /**
+ * This override the pulsar admin client
+ * netty EventLoopGroup when admin is created on the broker side.
+ * @param eventLoopGroup
+ * @return this
+ */
+ PulsarAdminBuilder setEventLoopGroup(EventLoopGroup eventLoopGroup);
+
+ /**
+ * This override the pulsar admin client
+ * netty Timer when admin is created on the broker side.
+ * @param nettyTimer
+ * @return this
+ */
+ PulsarAdminBuilder setNettyTimer(Timer nettyTimer);
+
Review Comment:
This cannot be exposed on the public API. It will cause issues on the shaded
client since the Netty packages are shaded. The decision has been to hide this
type of details from the public API.
Please see PIP-234 discussion about this:
https://lists.apache.org/thread/5jw06hqlmwnrgvbn9lfom1vkwhwqwwd4 .
A temporary solution is to make this possible in the private API such as has
been done for the Pulsar Client currently. Hopefully we eventually find a
solution for PIP-234. The design hasn't been completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
