michaeljmarshall commented on code in PR #20468:
URL: https://github.com/apache/pulsar/pull/20468#discussion_r1214844604
##########
pulsar-function-go/pf/instanceConf.go:
##########
@@ -42,6 +42,11 @@ type instanceConf struct {
killAfterIdle time.Duration
expectedHealthCheckInterval int32
metricsPort int
+ authPlugin string
+ authParams string
+ tlsCertsPath string
Review Comment:
Nit: I think we want this to be `tlsTrustCertsPath`. In the project, we
typically use `tlsCertsPath` to be a server's public certs that get sent to the
client.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
