michaeljmarshall commented on code in PR #20398: URL: https://github.com/apache/pulsar/pull/20398#discussion_r1214861181
########## tests/integration/src/test/java/org/apache/pulsar/tests/integration/bookkeeper/BrokerInstallWithEntryMetadataInterceptorsTest.java: ########## @@ -0,0 +1,68 @@ +package org.apache.pulsar.tests.integration.bookkeeper; + +import lombok.extern.slf4j.Slf4j; +import org.apache.pulsar.tests.integration.docker.ContainerExecResult; +import org.apache.pulsar.tests.integration.topologies.PulsarCluster; +import org.apache.pulsar.tests.integration.topologies.PulsarClusterSpec; +import org.apache.pulsar.tests.integration.topologies.PulsarClusterTestBase; +import org.testng.annotations.AfterClass; +import org.testng.annotations.BeforeClass; +import org.testng.annotations.Test; + +import java.util.stream.Stream; + +import static java.util.stream.Collectors.joining; +import static org.testng.AssertJUnit.assertEquals; + +/*** + * Test that verifies that regression in BookKeeper 4.16.0 is fixed. + * + * Anti-regression test for issue https://github.com/apache/pulsar/issues/20091. + */ +@Slf4j +public class BrokerInstallWithEntryMetadataInterceptorsTest extends PulsarClusterTestBase { + private static final String PREFIX = "PULSAR_PREFIX_"; + + @BeforeClass(alwaysRun = true) + @Override + public final void setupCluster() throws Exception { + incrementSetupNumber(); + + final String clusterName = Stream.of(this.getClass().getSimpleName(), randomName(5)) + .filter(s -> !s.isEmpty()) + .collect(joining("-")); + brokerEnvs.put(PREFIX + "exposingBrokerEntryMetadataToClientEnabled", "true"); + brokerEnvs.put(PREFIX + "brokerEntryMetadataInterceptors", "org.apache.pulsar.common.intercept.AppendBrokerTimestampMetadataInterceptor"); Review Comment: It's probably sufficient to do it either way. We're not testing the specific interceptor so much as the integration with the bookkeeper client. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
