AnonHxy commented on code in PR #20481:
URL: https://github.com/apache/pulsar/pull/20481#discussion_r1216343332
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -3119,9 +3120,11 @@ private Response generateResponseWithEntry(Entry entry)
throws IOException {
ResponseBuilder responseBuilder = Response.ok();
responseBuilder.header("X-Pulsar-Message-ID", pos.toString());
- for (KeyValue keyValue : metadata.getPropertiesList()) {
- responseBuilder.header("X-Pulsar-PROPERTY-" + keyValue.getKey(),
keyValue.getValue());
- }
+
+ Map<String, String> properties = metadata.getPropertiesList().stream()
+ .collect(Collectors.toMap(KeyValue::getKey,
KeyValue::getValue, (v1, v2) -> v2));
+ responseBuilder.header("X-Pulsar-PROPERTY", new
Gson().toJson(properties));
Review Comment:
LGTM and we'd better release at 3.1.0， not3.1.x
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -3119,9 +3120,11 @@ private Response generateResponseWithEntry(Entry entry)
throws IOException {
ResponseBuilder responseBuilder = Response.ok();
responseBuilder.header("X-Pulsar-Message-ID", pos.toString());
- for (KeyValue keyValue : metadata.getPropertiesList()) {
- responseBuilder.header("X-Pulsar-PROPERTY-" + keyValue.getKey(),
keyValue.getValue());
- }
+
+ Map<String, String> properties = metadata.getPropertiesList().stream()
+ .collect(Collectors.toMap(KeyValue::getKey,
KeyValue::getValue, (v1, v2) -> v2));
+ responseBuilder.header("X-Pulsar-PROPERTY", new
Gson().toJson(properties));
Review Comment:
LGTM and we'd better release at 3.1.0， not3.0.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
