This is an automated email from the ASF dual-hosted git repository.

mmarshall pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/branch-3.0 by this push:
     new 965cb3829bd [fix][fn] Go functions need to use static grpcPort in k8s 
runtime (#20404)
965cb3829bd is described below

commit 965cb3829bdcbaed4572c811384c7f9b0b6e7d67
Author: Andy Walker <[email protected]>
AuthorDate: Mon Jun 5 09:16:51 2023 -0400

    [fix][fn] Go functions need to use static grpcPort in k8s runtime (#20404)
    
    (cherry picked from commit 7e6ca31dcb7bd04afff4daf50ac44be4749b6f2b)
---
 .../functions/runtime/kubernetes/KubernetesRuntimeFactory.java       | 5 +++++
 .../pulsar/functions/runtime/kubernetes/KubernetesRuntimeTest.java   | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git 
a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeFactory.java
 
b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeFactory.java
index 3e1d40e80dc..bbb6e3992a0 100644
--- 
a/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeFactory.java
+++ 
b/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeFactory.java
@@ -302,6 +302,11 @@ public class KubernetesRuntimeFactory implements 
RuntimeFactory {
                 .map((customizer) -> 
customizer.customizeName(instanceConfig.getFunctionDetails(), jobName))
                 .orElse(jobName);
 
+        // pass grpcPort configured in functionRuntimeFactoryConfigs.grpcPort 
in functions_worker.yml
+        if (grpcPort != null) {
+            instanceConfig.setPort(grpcPort);
+        }
+
         // pass metricsPort configured in 
functionRuntimeFactoryConfigs.metricsPort in functions_worker.yml
         if (metricsPort != null) {
             instanceConfig.setMetricsPort(metricsPort);
diff --git 
a/pulsar-functions/runtime/src/test/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeTest.java
 
b/pulsar-functions/runtime/src/test/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeTest.java
index d6135737c4f..2cbbeb8a00b 100644
--- 
a/pulsar-functions/runtime/src/test/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeTest.java
+++ 
b/pulsar-functions/runtime/src/test/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntimeTest.java
@@ -984,7 +984,7 @@ public class KubernetesRuntimeTest {
         assertEquals(goInstanceConfig.get("disk"), 10000);
         assertEquals(goInstanceConfig.get("instanceID"), 0);
         assertEquals(goInstanceConfig.get("cleanupSubscription"), false);
-        assertEquals(goInstanceConfig.get("port"), 0);
+        assertEquals(goInstanceConfig.get("port"), 4332);
         assertEquals(goInstanceConfig.get("subscriptionType"), 0);
         assertEquals(goInstanceConfig.get("timeoutMs"), 0);
         assertEquals(goInstanceConfig.get("subscriptionName"), "");

Reply via email to