BewareMyPower commented on code in PR #277:
URL: https://github.com/apache/pulsar-client-cpp/pull/277#discussion_r1219183350
##########
tests/brokermetadata/BrokerMetadataTest.cc:
##########
@@ -25,19 +25,58 @@ using namespace pulsar;
TEST(BrokerMetadataTest, testConsumeSuccess) {
Client client{"pulsar://localhost:6650"};
Producer producer;
- Result producerResult =
client.createProducer("persistent://public/default/testConsumeSuccess",
producer);
+ ProducerConfiguration producerConfiguration;
+ producerConfiguration.setBatchingEnabled(false);
Review Comment:
The only difference between these two tests is here. I think you can use
`INSTANTIATE_TEST_SUITE_P` to reduce duplicated code. See `AcknowledgeTest.cc`
for example.
But it's only an improvement. If you think it's too complicated, just
resolve this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
