tisonkun commented on issue #19866: URL: https://github.com/apache/pulsar/issues/19866#issuecomment-1579859518
@JooHyukKim If you take a closer look at https://github.com/apache/pulsar/issues/19866#issuecomment-1556077694, it supports fallback to `serviceUrl` when `brokerServiceUrl` is not configured. The other use case of `ClientDataImpl` is: https://github.com/apache/pulsar/blob/aa7decc5b75894e864f3c5962c5cffad255abf25/pulsar-broker/src/main/java/org/apache/pulsar/broker/lookup/TopicLookupBase.java#L239-L245 So...I must say here we have a series of config problems: * Can `serviceUrl` be a legacy option key of `brokerServiceUrl`? * Can `serviceUrlTls` be a legacy option key of `brokerServiceUrlTls`? * What's more vague, `tlsEnable` is deprecated and it seems no options fall back here, but it's dependent by `NamespaceService` logics. Perhaps we can open a new issue to investigate these issues and see if we can have a clear model. > we still need to fix all tests that configures only one of ServiceUrl or BrokerServiceUrl. Theoretically, I agree, while it's already different from the proposal of this issue: > verify that there is at least one serviceUrl/serviceUrlTls and at least one brokerServiceUrl/brokerServiceUrlTls set. ... although, if `BrokerServiceUrl` takes precedence over `ServiceUrl`, perhaps a warning is enough. That said, a clear model of these options is somehow missing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
