asafm commented on code in PR #20507: URL: https://github.com/apache/pulsar/pull/20507#discussion_r1221328975
########## pip/pip-275.md: ########## @@ -0,0 +1,59 @@ +<!-- Review Comment: If you're done can you please remove all comments? ########## pip/pip-275.md: ########## @@ -0,0 +1,59 @@ +<!-- +RULES +* Never place a link to an external site like Google Doc. The proposal should be in this issue entirely. +* Use a spelling and grammar checker tools if available for you (there are plenty of free ones). + +PROPOSAL HEALTH CHECK +I can read the design document and understand the problem statement and what you plan to change *without* resorting to a couple of hours of code reading just to start having a high level understanding of the change. + +THIS COMMENTS +Please remove them when done. +--> + +# Background knowledge Review Comment: I can't even start to read this PIP as vital background information needs to be included. Can you please read the comment for the background knowledge section and add it accordingly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
