[pulsar] branch master updated: [improve][admin] Pretty print bookies racks-placement command output (#20516)

[tison]

This is an automated email from the ASF dual-hosted git repository.

tison pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git


The following commit(s) were added to refs/heads/master by this push:
     new c39f7bb123a [improve][admin] Pretty print bookies racks-placement 
command output (#20516)
c39f7bb123a is described below

commit c39f7bb123a995538fc8fa9a54b572c73fee39db
Author: vineeth1995 <vineethreddypo...@gmail.com>
AuthorDate: Thu Jun 8 01:10:27 2023 -0700

    [improve][admin] Pretty print bookies racks-placement command output 
(#20516)
---
 .../src/main/java/org/apache/pulsar/admin/cli/CliCommand.java  | 10 +++++++++-
 .../src/main/java/org/apache/pulsar/admin/cli/CmdBookies.java  |  2 +-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git 
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CliCommand.java 
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CliCommand.java
index 7a6836eb747..c96b0bd4365 100644
--- 
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CliCommand.java
+++ 
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CliCommand.java
@@ -214,13 +214,21 @@ public abstract class CliCommand {
             if (item instanceof String) {
                 System.out.println(item);
             } else {
-                System.out.println(writer.writeValueAsString(item));
+                prettyPrint(item);
             }
         } catch (Exception e) {
             throw new RuntimeException(e);
         }
     }
 
+    <T> void prettyPrint(T item) {
+        try {
+            System.out.println(writer.writeValueAsString(item));
+        } catch (Exception e) {
+            throw new RuntimeException(e);
+        }
+    }
+
     private static ObjectMapper mapper = ObjectMapperFactory.create();
     private static ObjectWriter writer = 
mapper.writerWithDefaultPrettyPrinter();
     private static Set<Character> sizeUnit = Sets.newHashSet('k', 'K', 'm', 
'M', 'g', 'G', 't', 'T');
diff --git 
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdBookies.java 
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdBookies.java
index 8c8f0f4e8a2..27502a305ac 100644
--- 
a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdBookies.java
+++ 
b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdBookies.java
@@ -35,7 +35,7 @@ public class CmdBookies extends CmdBase {
 
         @Override
         void run() throws Exception {
-            print(getAdmin().bookies().getBookiesRackInfo());
+            prettyPrint(getAdmin().bookies().getBookiesRackInfo());
         }
     }