asafm commented on code in PR #20455: URL: https://github.com/apache/pulsar/pull/20455#discussion_r1222973189
########## pip/pip-272.md: ########## @@ -59,8 +59,8 @@ Make `StateStoreProvider` "truly" configurable, custom `StateStoreProvider` can # High Level Design -We will add a configuration key to the Pulsar Function Worker configuration, containing the configuration for the `StateStoreProvider` implementation as a `Map<String, Object>`. -This `Map<String, Object>`, will be trickled down to different runtimes, all the way to `JavaInstanceRunnable`, the ultimate Main class all runtimes use to execute the function. +We will add a configuration key to the Pulsar Function Worker configuration, containing the configuration for the `StateStoreProvider` implementation as a `Map`. Review Comment: ```suggestion We will add a configuration key to the Pulsar Function Worker configuration, containing the configuration for the `StateStoreProvider`. Its value type will be a YAML `Map`. ``` ########## pip/pip-272.md: ########## @@ -59,8 +59,8 @@ Make `StateStoreProvider` "truly" configurable, custom `StateStoreProvider` can # High Level Design -We will add a configuration key to the Pulsar Function Worker configuration, containing the configuration for the `StateStoreProvider` implementation as a `Map<String, Object>`. -This `Map<String, Object>`, will be trickled down to different runtimes, all the way to `JavaInstanceRunnable`, the ultimate Main class all runtimes use to execute the function. +We will add a configuration key to the Pulsar Function Worker configuration, containing the configuration for the `StateStoreProvider` implementation as a `Map`. +This `Map`, will be trickled down to different runtimes, all the way to `JavaInstanceRunnable`, the ultimate Main class all runtimes use to execute the function. Review Comment: ```suggestion This `Map`, will trickle down to different runtimes, all the way to `JavaInstanceRunnable`, the ultimate Main class all runtimes use to execute the function. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
