eolivelli commented on code in PR #20552:
URL: https://github.com/apache/pulsar/pull/20552#discussion_r1224461696
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:
##########
@@ -1103,6 +1134,10 @@ public OwnershipCache getOwnershipCache() {
}
public Set<NamespaceBundle> getOwnedServiceUnits() {
+ if (ExtensibleLoadManagerImpl.isLoadManagerExtensionEnabled(config)) {
Review Comment:
Honestly, having all these references to a specific implementation
(ExtensibleLoadManagerImpl) is a code smell.
We should rely on object oriented programming principals.
I am not going to block this patch, but I think that we are accumulating
some tech debt that we will have to pay later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
