lifepuzzlefun commented on PR #20506: URL: https://github.com/apache/pulsar/pull/20506#issuecomment-1587476134
thanks for the review. after write a jmh test it seems the performance not that good if LongAdder `add` and `get` have 1:1 access call. the jmh test here. https://gist.github.com/lifepuzzlefun/03f9333a8f33c32c66e63ea4ba40f7fb the result Benchmark Mode Cnt Score Error Units IteratorTest.longAdder thrpt 25 40.073 ± 0.443 ops/us IteratorTest.longCounter thrpt 25 41.377 ± 1.111 ops/us I'll try to be more careful next time : - ) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
