BewareMyPower commented on issue #193: URL: https://github.com/apache/pulsar-client-cpp/issues/193#issuecomment-1588735715
@tisonkun In the original PR (https://github.com/apache/pulsar/pull/11388/), the descriptor is retrieved from the class (`ExternalMessage`). ```c++ ASSERT_EQ(ResultIncompatibleSchema, createProducerResult(::proto::external::ExternalMessage::GetDescriptor())); ``` I just verified that my local protobuf (3.21.1) also generates the static method. ```c++ #define GOOGLE_PROTOBUF_VERSION 3021012 ``` ```c++ static const ::PROTOBUF_NAMESPACE_ID::Descriptor* GetDescriptor() { return default_instance().GetMetadata().descriptor; } ``` Then I tried generating the files with Protobuf 3.19.2, the generated `GetDescriptor` method is still static. So I think it is not necessary to do conditional compile here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
