315157973 commented on code in PR #20537:
URL: https://github.com/apache/pulsar/pull/20537#discussion_r1229245109
##########
pulsar-broker/src/main/java/org/apache/pulsar/common/naming/NamespaceBundleFactory.java:
##########
@@ -68,6 +69,10 @@ public class NamespaceBundleFactory {
private final AsyncLoadingCache<NamespaceName, NamespaceBundles>
bundlesCache;
private final PulsarService pulsar;
+
+ @Getter
+ private final TopicBundleAssignmentStrategy topicBundleAssignmentStrategy;
Review Comment:
It is better to create the strategy as a singleton field in
`TopicBundleAssignmentFactory` instead of `NamespaceBundleFactory`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
