mattisonchao commented on code in PR #20569:
URL: https://github.com/apache/pulsar/pull/20569#discussion_r1230604200
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/impl/SnapshotSegmentAbortedTxnProcessorImpl.java:
##########
@@ -381,10 +382,11 @@ public void
openReadOnlyManagedLedgerFailed(ManagedLedgerException exception, Ob
// This method will be deprecated and removed in version 4.x.0
private CompletableFuture<PositionImpl> recoverOldSnapshot() {
- return
topic.getBrokerService().getTopic(TopicName.get(topic.getName()).getNamespace()
+ "/"
- + SystemTopicNames.TRANSACTION_BUFFER_SNAPSHOT, false)
- .thenCompose(topicOption -> {
- if (!topicOption.isPresent()) {
+ return
topic.getBrokerService().getPulsar().getPulsarResources().getTopicResources()
+
.listPersistentTopicsAsync(NamespaceName.get(TopicName.get(topic.getName()).getNamespace()))
+ .thenCompose(topics -> {
Review Comment:
I just worry about if we have any logic in the transaction component
**block** this thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
