TakaHiR07 commented on code in PR #20583:
URL: https://github.com/apache/pulsar/pull/20583#discussion_r1231914628


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -1184,7 +1184,6 @@ protected void handleSubscribe(final CommandSubscribe 
subscribe) {
                         ServerError error = 
getErrorCodeWithErrorLog(existingConsumerFuture, true,
                                 String.format("Consumer subscribe failure. 
remoteAddress: %s, subscription: %s",
                                         remoteAddress, subscriptionName));
-                        consumers.remove(consumerId, existingConsumerFuture);

Review Comment:
   ```
   11:35:42.794 [pulsar-io-4-39] INFO  
org.apache.pulsar.broker.service.ServerCnx - [/host1:ip1] Subscribing on topic 
persistent://xxx/xxx/topic-partition-3 / subscription-xxx-1
   
   11:36:12.793 [pulsar-io-4-39] INFO  
org.apache.pulsar.broker.service.ServerCnx - [/host1:ip1] Closing consumer: 
consumerId=3
   11:36:12.793 [pulsar-io-4-39] INFO  
org.apache.pulsar.broker.service.ServerCnx - [/host1:ip1] Closed consumer 
before its creation was completed. consumerId=3
   
   11:36:12.990 [pulsar-io-4-39] INFO  
org.apache.pulsar.broker.service.ServerCnx - [/host1:ip1] Subscribing on topic 
persistent://xxx/xxx/topic-partition-3 / subscription-xxx-1
   11:36:12.990 [pulsar-io-4-39] ERROR 
org.apache.pulsar.broker.service.ServerCnx - Consumer subscribe failure. 
remoteAddress: /host1:ip1, subscription: subscription-xxx-1
   java.util.concurrent.CompletionException: java.lang.IllegalStateException: 
Closed consumer before creation was complete
   
   11:36:13.389 [pulsar-io-4-39] INFO  
org.apache.pulsar.broker.service.ServerCnx - [/host1:ip1] Subscribing on topic 
persistent://xxx/xxx/topic-partition-3 / subscription-xxx-1
   
   11:36:13.685 [broker-topic-workers-OrderedScheduler-1-0] INFO  
org.apache.pulsar.broker.service.ServerCnx - [/host1:ip1] Created subscription 
on topic persistent://xxx/xxx/topic-partition-3 / subscription-xxx-1
   
   
   11:36:13.706 [broker-topic-workers-OrderedScheduler-1-0] INFO  
org.apache.pulsar.broker.service.persistent.PersistentDispatcherMultipleConsumers
 - Removed consumer 
Consumer{subscription=PersistentSubscription{topic=persistent://xxx/xxx/topic-partition-3,
 name=subscription-xxx-1}, consumerId=3, consumerName=2b83e9380c, 
address=/host1:ip1} with pending 0 acks
   
   11:36:13.706 [broker-topic-workers-OrderedScheduler-1-0] INFO  
org.apache.pulsar.broker.service.ServerCnx - [/host1:ip1] Cleared consumer 
created after timeout on client side 
Consumer{subscription=PersistentSubscription{topic=persistent://xxx/xxx/topic-partition-3,
 name=subscription-xxx-1}, consumerId=3, consumerName=2b83e9380c, 
address=/host1:ip1}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to