Technoboy- commented on code in PR #20518: URL: https://github.com/apache/pulsar/pull/20518#discussion_r1231996812
########## pip/pip-274.md: ########## @@ -0,0 +1,65 @@ +# Motivation + +The metrics are all started with `pulsar_`, so that both users and operators can quickly find the metrics of the entire system through this prefix. However, due to some other reasons, +it was found that `topic_load_times` was missing the prefix, so want to get it right. + +# Goals + +## In Scope + +### Proposed changes Review Comment: yes, thanks for reviewing. Addressed ########## pip/pip-274.md: ########## @@ -0,0 +1,65 @@ +# Motivation + +The metrics are all started with `pulsar_`, so that both users and operators can quickly find the metrics of the entire system through this prefix. However, due to some other reasons, +it was found that `topic_load_times` was missing the prefix, so want to get it right. + +# Goals + +## In Scope + +### Proposed changes + +In master branch, keep the old metric `topic_load_times` and add below new metrics: + +* `pulsar_topic_load_times` + +After release-3.1.0, remove ``topic_load_times`. + +## Out of Scope + + + +# High Level Design + + + +# Detailed Design + +## Design & Implementation Details + + + +## Public-facing Changes + + + +### Public API Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
