michaeljmarshall commented on code in PR #19464:
URL: https://github.com/apache/pulsar/pull/19464#discussion_r1232796567
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/web/AuthenticationFilter.java:
##########
@@ -52,19 +52,29 @@ public AuthenticationFilter(AuthenticationService
authenticationService) {
@Override
public void doFilter(ServletRequest request, ServletResponse response,
FilterChain chain)
throws IOException, ServletException {
+ boolean allowed = false;
+ Exception authenticationException = null;
try {
- boolean doFilter = authenticationService
+ allowed = authenticationService
Review Comment:
Nit: `allowed` is a misleading variable name here. From my perspective, the
correct name was `doFilter`. In some cases, like in SASL, it returns `false`
because there is additional work to be done before proceeding. I don't think
anything is incorrect about the logic, just commenting on the name.
See:
https://github.com/apache/pulsar/blob/82237d3684fe506bcb6426b3b23f413422e6e4fb/pulsar-broker-auth-sasl/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProviderSasl.java#L229-L312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
