nodece commented on code in PR #19464:
URL: https://github.com/apache/pulsar/pull/19464#discussion_r1232987888
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/web/AuthenticationFilter.java:
##########
@@ -52,19 +52,29 @@ public AuthenticationFilter(AuthenticationService
authenticationService) {
@Override
public void doFilter(ServletRequest request, ServletResponse response,
FilterChain chain)
throws IOException, ServletException {
+ boolean allowed = false;
+ Exception authenticationException = null;
try {
- boolean doFilter = authenticationService
+ allowed = authenticationService
Review Comment:
> Then let me take my comment above and a follow-up #20598 - none of
intermediate mutable variables are needed.
I don't think we should remove the `allowed` var. Only when `allowed` is
`true`, we can do call next filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
